Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use native logging instead of print the error message again #550

Merged
merged 1 commit into from
Feb 20, 2023
Merged

Use native logging instead of print the error message again #550

merged 1 commit into from
Feb 20, 2023

Conversation

puppetninja
Copy link
Collaborator

@puppetninja puppetninja commented Feb 20, 2023 •
edited
Loading

original usage of logger was changed to print by this commit
c837cac#diff-06e9c476e5103458bda025d8f6beac772713d2d4466985ae3752b672b7a9c0eaL49
I think this is not intentional, so I create this PR to change it back again.

@orcutt989
Copy link
Contributor

orcutt989 commented Feb 20, 2023 •
edited
Loading

@puppetninja Thanks for the improvement!! Would you mind updating the description with the how and the why? I know it seems like a trivial change, but I would like to learn more about this. Thanks 😁 I am a big fan of this methodology https://github.blog/2015-01-21-how-to-write-the-perfect-pull-request/. Does not need to be so in-depth, but I think it could provide some good ideas.

@puppetninja
Copy link
Collaborator Author

@puppetninja Thanks for the improvement!! Would you mind updating the description with the how and the why? I know it seems like a trivial change, but I would like to learn more about this. Thanks grin I am a big fan of this methodology https://github.blog/2015-01-21-how-to-write-the-perfect-pull-request/. Does not need to be so in-depth, but I think it could provide some good ideas.

Hi @orcutt989 yes, I updated the description

@puppetninja puppetninja merged commit 76c7bec into master Feb 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicolasochem nicolasochem nicolasochem approved these changes

@orcutt989 orcutt989 orcutt989 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@puppetninja @orcutt989 @nicolasochem